generated from pharmaverse/admiraltemplate
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
253 feature request deprecatesupersede derive vars crit #254
Merged
ahasoplakus
merged 27 commits into
main
from
253-feature-request-deprecatesupersede-derive_vars_crit
Jan 28, 2025
Merged
253 feature request deprecatesupersede derive vars crit #254
ahasoplakus
merged 27 commits into
main
from
253-feature-request-deprecatesupersede-derive_vars_crit
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobaratin
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
final review
Addressing comments from the final review of Admiral team
labels
Dec 12, 2024
ahasoplakus
requested review from
ahasoplakus and
manciniedoardo
and removed request for
vikrams95
December 12, 2024 14:37
ahasoplakus
requested changes
Dec 12, 2024
Hi @federicobaratin I made some changes to yours to align with the phase 1 deprecation strategy of |
ahasoplakus
approved these changes
Jan 13, 2025
manciniedoardo
suggested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my review comments, thanks
ahasoplakus
approved these changes
Jan 28, 2025
ahasoplakus
deleted the
253-feature-request-deprecatesupersede-derive_vars_crit
branch
January 28, 2025 10:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
final review
Addressing comments from the final review of Admiral team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()